Re: [PATCH 4/4] built-in rebase: call `git am` directly

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 7, 2019, 17:19 UTC
Message-ID: <xmqqef9o9yhf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqqbm4wau51.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
>> While the scripted `git rebase` still has to rely on the
>> `git-rebase--am.sh` script to implement the glue between the `rebase`
>> and the `am` commands, we can go a more direct route in the built-in
>> rebase and avoid using a shell script altogether.
>
>  ...
>
>>  builtin/rebase.c | 183 +++++++++++++++++++++++++++++++++++++++++++++++
>
> Now at some point as a follow-up change, we'd need to remove the
> git-rebase--am.sh that is no longer used, together with the
> reference to it in the Makefile, no?

Answering to myself. That needs to wait until the legacy-rebase is retired, so it's not like "immediately after this series is done" kind of thing.

Anyway, thanks for working on this.