git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: fix a couple spelling errors in comments

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 4, 2020, 23:51 UTC
Message-ID
<xmqqeewebx1w.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200104173923.45537050@basepc>
Denis Ovsienko <denis@ovsienko.info> writes:
Show 6 quoted lines
> Date: Sat, 4 Jan 2020 17:33:55 +0000
>
> Signed-off-by: Denis Ovsienko <denis@ovsienko.info>
> ---
>  gitweb/gitweb.perl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
Both of these typofixes look correct.

By the way, please do not attempt to override the author timestamp with an in-body header when contributing to this project, as the time the general public sees the patch on the list is when they perceive as the time the patch appeared in this world for the first time, as far as this list is concerned.

Thanks.
Show 23 quoted lines
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 0f857d790b..65a3a9e62e 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -741,7 +741,7 @@ sub evaluate_gitweb_config {
>  	$GITWEB_CONFIG_SYSTEM = "" if ($GITWEB_CONFIG_SYSTEM eq $GITWEB_CONFIG_COMMON);
>  
>  	# Common system-wide settings for convenience.
> -	# Those settings can be ovverriden by GITWEB_CONFIG or GITWEB_CONFIG_SYSTEM.
> +	# Those settings can be overridden by GITWEB_CONFIG or GITWEB_CONFIG_SYSTEM.
>  	read_config_file($GITWEB_CONFIG_COMMON);
>  
>  	# Use first config file that exists.  This means use the per-instance
> @@ -5285,7 +5285,7 @@ sub format_ctx_rem_add_lines {
>  		#    + c
>  		#   +  d
>  		#
> -		# Otherwise the highlightling would be confusing.
> +		# Otherwise the highlighting would be confusing.
>  		if ($is_combined) {
>  			for (my $i = 0; $i < @$add; $i++) {
>  				my $prefix_rem = substr($rem->[$i], 0, $num_parents);
Previous: Denis Ovsienko
Message 2 of 2 in “gitweb: fix a couple spelling errors in comments”
  1. gitweb: fix a couple spelling errors in commentsDenis Ovsienko, Jan 4, 2020
  2. Junio C HamanoJan 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.