git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] diff: only prefetch for certain output formats

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 31, 2020, 18:08 UTC
Message-ID
<xmqqeevfbisb.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200131001416.GB2394563@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> fetches anything at all). I.e., for "diff -M -p", you'd want:
>
>   1. diffcore_std() sees "-p" and fetches everything
>
>   2. diffcore_rename() sees there's nothing we don't already have
>
> rather than:
>
>   1. diffcore_rename() fetches a few blobs to do rename detection
>
>   2. diffcore_std() fetches a few more blobs that weren't rename
>      candidates, but we need for "-p"

Hmph, a pure rename only change will cause no blobs transferred with the latter (because there is no content change for "-p" to report, and the rename detection for R100 paths would be done at the object name level), but all blobs in filepairs (before rename matches A/D up) with the former, no?

Previous: Jeff KingNext: Jeff King
Message 7 of 8 in “diff: only prefetch for certain output formats”
  1. diff: only prefetch for certain output formatsJonathan Tan, Jan 28, 2020
  2. Jeff KingJan 29, 2020
  3. Jonathan TanJan 30, 2020
  4. Jeff KingJan 30, 2020
  5. Jonathan TanJan 30, 2020
  6. Jeff KingJan 31, 2020
  7. Junio C HamanoJan 31, 2020
  8. Jeff KingFeb 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.