Re: [PATCH] experimental: default to fetch.writeCommitGraph=false

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 7, 2020, 16:50 UTC
Message-ID: <xmqqeepn5kxz.fsf@gitster.c.googlers.com>
In-Reply-To: <20200707151735.GA27992@syl.lan>

Taylor Blau <me@ttaylorr.com> writes:

Show 10 quoted lines

>> I wonder if we perhaps wnat to add to the documentation for
>> writeCommitGraph configuration that its use is currently not
>> recommended in a shallow clone or something (I know it is not
>> a problem just to use it with shallow but the breakage needs
>> to involve unshallowing, but by definition those who do not
>> use shallow would not hit the unshallowing bug, so...).
>
> I think this is a good direction if you don't want to take the patch I
> sent in [1] for v2.28.0. If you do, though, I don't think that this
> would be necessary.

Good timing. I didn't know a "fix" was already being worked on ([1] is the patch from this morning, right? I haven't seen it except for its subject).

We could obviously do both excluding it from the usual experimental set and applying your fix, so that those who are really curious can help us make sure your fix would be all that is needed. Let's see what Jonathan says...

Thanks.