Re: [PATCH v2] userdiff: expand detected chunk headers for css

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 8, 2020, 17:23 UTC
Message-ID: <xmqqeem8y6ld.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.866.v2.git.git.1602146164799.gitgitgadget@gmail.com>

"Sohom Datta via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Sohom <sohom.datta@learner.manipal.edu>

I'd call this line *1* for later reference...

Show 15 quoted lines

> The regex used for the CSS builtin diff driver in git is only
> able to show chunk headers for lines that start with a number,
> a letter or an underscore.
>
> However, the regex fails to detect classes (starts with a .), ids
> (starts with a #), :root and attribute-value based selectors (for
> example [class*="col-"]), as well as @based block-level statements
> like @page,@keyframes and @media since all of them, start with a
> special character.
>
> Allow the selectors and block level statements to begin with these
> special characters.
>
> Signed-off-by: Sohom Datta <sohom.datta@learner.manipal.edu>
> ---

Looking good.

The "Name <email>" on line *1* must match that on the last "signed-off-by" line, so I'll locally tweak the authorship information before applying the patch.

Thanks.