git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] git-send-email: Respect core.hooksPath setting

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 23, 2021, 22:40 UTC
Message-ID
<xmqqeeg51ojs.fsf@gitster.g>
In-Reply-To
<patch-1.1-cc0ba73974a-20210323T173032Z-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
Show 22 quoted lines
> From: Robert Foss <robert.foss@linaro.org>
>
> get-send-email currently makes the assumption that the
> 'sendemail-validate' hook exists inside of the repository.
>
> Since the introduction of 'core.hooksPath' configuration option in
> 867ad08a261 (hooks: allow customizing where the hook directory is,
> 2016-05-04), this is no longer true.
>
> Instead of assuming a hardcoded repo relative path, query
> git for the actual path of the hooks directory.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>
> Here's a v3 that fixes various issues with Robert's v2. Range-diff &
> updated patch below.
>
> The advice I had in the v1 feedback about GetHooksPath was bad, just
> having it be a new accessor is better. It's not like anyone is calling
> this in a loop.

How urgent is this "fix". I am wondering if Emily's "git hook" automatically fix this for us when it comes.

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 3 of 5 in “git-send-email: Respect core.hooksPath setting”
  1. git-send-email: Respect core.hooksPath settingRobert Foss, Mar 23, 2021
  2. git-send-email: Respect core.hooksPath settingÆvar Arnfjörð Bjarmason, Mar 23, 2021
  3. Junio C HamanoMar 23, 2021
  4. Ævar Arnfjörð BjarmasonMar 24, 2021
  5. Junio C HamanoMar 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.