Re: [PATCH v3] help.c: help.autocorrect=prompt waits for user action

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2021, 00:18 UTC
Message-ID: <xmqqee9z9ayf.fsf@gitster.g>
In-Reply-To: <pull.1012.v3.git.1628992226139.gitgitgadget@gmail.com>

"Azeem Bande-Ali via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 17 quoted lines

> From: Azeem Bande-Ali <me@azeemba.com>
>
> If help.autocorrect is set to 'prompt', the user is prompted
> before the suggested action is executed.
>
> Based on original patch by David Barr
> https://lore.kernel.org/git/1283758030-13345-1-git-send-email-david.barr@cordelta.com/
>
> Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
> Signed-off-by: Azeem Bande-Ali <me@azeemba.com>
> ---
>     New config for help.autocorrect to prompt user before action
>     
>     Only minor style changes have been made since v2:
>     
>      * Moved * to variable name instead of the type name
>      * Keep code in the same line for readability

I didn't see anybody comment on this round (and do not think I saw anything glaringly wrong).

Is everybody happy with this version? I am about to mark it for 'next' in the next issue of "What's cooking" report, so please holler if I should wait.

Thanks.