git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ls-files: use imperative mood for -X and -z option description

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 20, 2021, 19:30 UTC
Message-ID
<xmqqee9javtd.fsf@gitster.g>
In-Reply-To
<YUij2Aj04B1Q1tRV@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 8 quoted lines
> Your patch looks fine to me. I don't think it's urgent to change, but it
> looks correct nonetheless.
>
>> Cc: Jeff King <peff@peff.net>
>> Cc: <liu.denton@gmail.com>
>
> These Cc trailers can be removed. (They're not entirely unprecedented,
> but I can only find ~200 examples in git.git's history).

Yup, "can" and probably "should". It is meant for consumption by your e-mail software.

Show 9 quoted lines
>>  		OPT_SET_INT('z', NULL, &line_terminator,
>> -			N_("paths are separated with NUL character"), '\0'),
>> +			N_("separate paths with NUL character"), '\0'),
>
> The text before your patch should include an article so it reads "with
> [the] NUL character" instead of "with NUL character".
>
> So I think the right post-image would be: "separate paths with the NUL
> character".

Correct. Grammar fixes are very much appreciated, especially in an international project like this one.

Thanks.
Previous: Taylor Blau
Message 3 of 3 in “ls-files: use imperative mood for -X and -z option description”
  1. ls-files: use imperative mood for -X and -z option descriptionBagas Sanjaya, Sep 20, 2021
  2. Taylor BlauSep 20, 2021
  3. Junio C HamanoSep 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.