Re: [PATCH] repack: respect --keep-pack with geometric repack
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 20, 2022, 22:12 UTC
- Message-ID
- <xmqqee0ng8fj.fsf@gitster.g>
- In-Reply-To
- <xmqqr14oey2a.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
>>> + /* >>> + * The pack may be kept via the --keep-pack option; >>> + * check 'existing_kept_packs' to determine whether to >>> + * ignore it. >>> + */ > > OK. So there are two classes of packs we want to exclude from the > geometry repacking. Those that already have .pack_keep bit set, and > those that are _are_ newly making into kept packs that do not yet > have .pack_keep bit set. Makes sense.
And with another topic in-flight combined, we have the third class that we would want to exclude here, i.e. the ones that are "cruft".
(Noticed while rebuilding 'seen').