Re: [PATCH v5 2/2] send-email: expose header information to git-send-email's sendemail-validate hook

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 14, 2023, 16:03 UTC
Message-ID: <xmqqedrxm7bn.fsf@gitster.g>
In-Reply-To: <20230110211452.2568535-3-michael.strawbridge@amd.com>

"Strawbridge, Michael" <Michael.Strawbridge@amd.com> writes:

> +test_expect_success $PREREQ "--validate hook supports header argument" '
> +	test_when_finished "rm my-hooks.ran" &&
> +	write_script my-hooks/sendemail-validate <<-\EOF &&
> +	filesize=$(stat -c%s "$2")

That "stat -c" is a GNU-ism, I think. macOS CI jobs at GitHub do not seem to like it.

> +	if [ "$filesize" != "0" ]; then

Also, please see Documentation/CodingGuidelines to learn the subset of shell script syntax and style we adopted for this project.

Thanks.