git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 1/1] check-attr: integrate with sparse-index

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 27, 2023, 18:51 UTC
Message-ID
<xmqqedqbt00v.fsf@gitster.g>
In-Reply-To
<cd7b9a2f-4f52-9da8-19c3-2c5cda7b8160@github.com>
Derrick Stolee <derrickstolee@github.com> writes:
Show 12 quoted lines
> Victoria is right that it is helpful to first establish test coverage of
> the builtin for correctness reasons before making this change. It helps to
> add tests for cases that would require expanding the sparse index, such as
> checking the attributes for paths outside of the sparse-checkout cone.
>
> Once the correctness tests are in place, you can then make this change to
> the builtin and add the tests that check ensure_not_expanded, since the
> change at that point is _only_ that we are allowing the builtin to
> operate upon the sparse index without expanding it immediately after read.
>
> A good example of this "final step" is [1], which updates the builtin for
> 'git diff' as well as adding _only_ the ensure_not_expanded tests.
Thanks for a detailed help.
Previous: Derrick StoleeNext: Shuqi Liang
Message 5 of 7 in “check-attr: integrate with sparse-index”
  1. 0/1 check-attr: integrate with sparse-indexShuqi Liang, Feb 27, 2023
  2. 1/1 check-attr: integrate with sparse-indexShuqi Liang, Feb 27, 2023
  3. Victoria DyeFeb 27, 2023
  4. Derrick StoleeFeb 27, 2023
  5. Junio C HamanoFeb 27, 2023
  6. Shuqi LiangFeb 28, 2023
  7. Victoria DyeFeb 27, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.