Re: How do we review changes made with coccinelle?

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 31, 2023, 18:17 UTC
Message-ID: <xmqqedp4g4z7.fsf@gitster.g>
In-Reply-To: <kl6lzg7sc01z.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

Show 8 quoted lines

> I agree, but I wonder what this means in practice when .cocci fluency is
> so low. Maybe:
>
> - We increase .cocci fluency, partly by creating our own learning
>   materials, partly by being more conscious about spreading knowledge
>   from the folks who are relatively fluent in it. We might not have to
>   do a lot to get the ball rolling either; just checking in a
>   "MyFirstCocci" would help a lot, I think.

I think it goes both ways. Readers of course must be willing to learn, but whoever proposes to add a .cocci patch file should be able to explain what the rewrite rules in there are designed to do and why. It is pretty much the same deal as any other patches.

I'll wait and prefer to hear from others, also on points that I did not even quote back in my message because I didn't have anything to add myself, before digging further on points I responded to.

Thanks for starting this topic.