Re: [PATCH] Fix memory leak in get_reachable_subset

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2023, 02:02 UTC
Message-ID: <xmqqedmt7167.fsf@gitster.g>
In-Reply-To: <20230603002819.1122129-1-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> Signed-off-by: Mike Hommey <mh@glandium.org>
> ---

As most lines in the affected function seems to come from your fcb2c076 (commit-reach: implement get_reachable_subset, 2018-11-02), I'll redirect the review of this patch to you.

Thanks.

Show 15 quoted lines

>  commit-reach.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/commit-reach.c b/commit-reach.c
> index 70bde8af05..f15d84566b 100644
> --- a/commit-reach.c
> +++ b/commit-reach.c
> @@ -944,6 +944,8 @@ struct commit_list *get_reachable_subset(struct commit **from, int nr_from,
>  		}
>  	}
>  
> +	clear_prio_queue(&queue);
> +
>  	clear_commit_marks_many(nr_to, to, PARENT1);
>  	clear_commit_marks_many(nr_from, from, PARENT2);