git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit-graph: retain commit slab when closing NULL commit_graph

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 5, 2024, 19:56 UTC
Message-ID
<xmqqedevo8ps.fsf@gitster.g>
In-Reply-To
<20240105054142.GA2035092@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> This fixes a regression introduced in ac6d45d11f (commit-graph: move
> slab-clearing to close_commit_graph(), 2023-10-03), in which running:
> ...
> So it happens to work out. But it still seems questionable to me that we
> would clear a global slab (which might still be in use) when closing the
> commit graph. This clearing comes from 957ba814bf (commit-graph: when
> closing the graph, also release the slab, 2021-09-08), and was fixing a
> case where we really did need it to be closed (and in that case we
> presumably call close_object_store() more directly).
Wow, that is nasty.

But anyway, thanks for your usual "3 pages of explanation for 2 lines of change". The patch does look the best fix in the meantime.

Previous: Junio C Hamano
Message 7 of 7 in “commit-graph: retain commit slab when closing NULL commit_graph”
  1. commit-graph: retain commit slab when closing NULL commit_graphJeff King, Jan 5, 2024
  2. Taylor BlauJan 5, 2024
  3. Jeff KingJan 10, 2024
  4. Junio C HamanoJan 10, 2024
  5. Jeff KingJan 11, 2024
  6. Junio C HamanoJan 11, 2024
  7. Junio C HamanoJan 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.