git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC] [PATCH] builtin/gc: Replace run_command with C function refs_pack_refs

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 28, 2024, 04:31 UTC
Message-ID
<xmqqedbvyo28.fsf@gitster.g>
In-Reply-To
<0a149be978e68271c251e80f8eb571f4@vkabc.me>
vk <g@vkabc.me> writes:
> I forgot to add this --auto optional logic. Will add it in the
> following patch.

Please slow down a bit. If you notice a problem in the patch you just posted within 7 minutes after posting it, there is a good chance that you are rushing it without carefully proofreading.

You'd be better off if you give yourself some time to think about what you wrote, after drafting your patch. Sleep on it, if needed.

There are issues in the patch. Trying to spot them yourself would give you a good exercise. Documentation/SubmittingPatches and Documentation/CodingGuidelines would be useful.

Thanks for your interest in Git development.
Previous: vk
Message 3 of 3 in “builtin/gc: Replace run_command with C function refs_pack_refs”
  1. vkMar 28, 2024
  2. vkMar 28, 2024
  3. Junio C HamanoMar 28, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.