git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Git Bug Report: git add --patch > "e" makes keyboard unresponsive

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 24, 2024, 22:23 UTC
Message-ID
<xmqqedauwgbk.fsf@gitster.g>
In-Reply-To
<Zil_m_1B0wcLejNH@tapette.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> Using the "e" option should invoke your editor and wait until it exits.
> The only way Git has to know that you're done editing is that the editor
> process it invokes has exited.

Whichever editor was launched, unless the user explicitly said the hint is not necessary by setting advice.waitingForEditor to false, the code should have given something like this:

    hint: Waiting for your editor to close the file...
so ...
> What does "git var GIT_EDITOR" at a Git Bash prompt print?  If you have
> your editor configured to open in an existing editor window, does
> closing the new editor tab or window that Git causes to be opened fix
> the problem?

... I would expect that there may be something more than a silly "the editor is running elsewhere and the user is stuck, expecting something to happen but the editor is waiting for the user" problem here. For example, could there be funny interaction with "single key" mode with editor on Windows (which I do not use myself but I think I saw the word in the original report)? Is the configuration "interactive.singlekey" enabled?

Previous: brian m. carlsonNext: Dan Demp
Message 3 of 12 in “Git Bug Report: git add --patch > "e" makes keyboard unresponsive”
  1. Dan DempApr 24, 2024
  2. brian m. carlsonApr 24, 2024
  3. Junio C HamanoApr 24, 2024
  4. Dan DempApr 25, 2024
  5. Junio C HamanoApr 25, 2024
  6. Dan DempApr 25, 2024
  7. Johannes SchindelinMar 16, 2025
  8. Junio C HamanoMar 17, 2025
  9. Releasing versions on Fridays, was Re: Git Bug Report: git add --patch > "e" makes keyboard unresponsiveJohannes Schindelin, Mar 25, 2025
  10. Junio C HamanoMar 25, 2025
  11. Johannes SchindelinMar 26, 2025
  12. Junio C HamanoMar 26, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.