Re: [PATCH 2/2] git-jump: ignore deleted files in diff mode

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 17, 2024, 15:03 UTC
Message-ID: <xmqqed5il3ui.fsf@gitster.g>
In-Reply-To: <ZulEwjnNQet6th8w@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 15 quoted lines

> On Sun, Sep 15, 2024 at 07:20:24AM -0400, Jeff King wrote:
>> diff --git a/contrib/git-jump/git-jump b/contrib/git-jump/git-jump
>> index 78e7394406..3f69675961 100755
>> --- a/contrib/git-jump/git-jump
>> +++ b/contrib/git-jump/git-jump
>> @@ -44,7 +44,7 @@ open_editor() {
>>  mode_diff() {
>>  	git diff --no-prefix --relative "$@" |
>>  	perl -ne '
>> -	if (m{^\+\+\+ (.*)}) { $file = $1; next }
>> +	if (m{^\+\+\+ (.*)}) { $file = $1 eq "/dev/null" ? undef : $1; next }
>
> I was surprised to not see you use `--diff-filter` here, but I think
> that that makes sense. You only would want to exclude deletions, since
> that would be the only time the post-image is /dev/null AFAICT.

So "--diff-filter=d" (lowercase)?