Re: What's cooking in git.git (Dec 2024, #05; Thu, 12)

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 16, 2024, 16:26 UTC
Message-ID: <xmqqed277fxb.fsf@gitster.g>
In-Reply-To: <Z1_gqiCuTZOdRVO0@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 25 quoted lines

> On Thu, Dec 12, 2024 at 09:31:06PM +0900, Junio C Hamano wrote:
>> * ps/build-sign-compare (2024-12-06) 16 commits
>>  - t/helper: don't depend on implicit wraparound
>>  - scalar: address -Wsign-compare warnings
>>  - builtin/patch-id: fix type of `get_one_patchid()`
>>  - builtin/blame: fix type of `length` variable when emitting object ID
>>  - gpg-interface: address -Wsign-comparison warnings
>>  - daemon: fix type of `max_connections`
>>  - daemon: fix loops that have mismatching integer types
>>  - global: trivial conversions to fix `-Wsign-compare` warnings
>>  - pkt-line: fix -Wsign-compare warning on 32 bit platform
>>  - csum-file: fix -Wsign-compare warning on 32-bit platform
>>  - diff.h: fix index used to loop through unsigned integer
>>  - config.mak.dev: drop `-Wno-sign-compare`
>>  - global: mark code units that generate warnings with `-Wsign-compare`
>>  - compat/win32: fix -Wsign-compare warning in "wWinMain()"
>>  - compat/regex: explicitly ignore "-Wsign-compare" warnings
>>  - git-compat-util: introduce macros to disable "-Wsign-compare" warnings
>> 
>>  Start working to make the codebase buildable with -Wsign-compare.
>> 
>>  Will merge to 'next'?
>>  source: <20241206-pks-sign-compare-v4-0-0344c6dfb219@pks.im>
>
> I think this series should be ready to go, yes.

OK, let me mark it for 'next', then. BTW, I found https://staticthinking.wordpress.com/2023/07/25/wsign-compare-is-garbage/ amusing ;-).

Show 13 quoted lines

>> * ps/send-pack-unhide-error-in-atomic-push (2024-11-14) 2 commits
>>  - transport: don't ignore git-receive-pack(1) exit code on atomic push
>>  - t5504: modernize test by moving heredocs into test bodies
>> 
>>  "git push --atomic --porcelain" used to ignore failures from the
>>  other side, losing the error status from the child process, which
>>  has been corrected.
>> 
>>  Needs review.
>>  source: <20241113-pks-push-atomic-respect-exit-code-v1-0-7965f01e7f4e@pks.im>
>
> There was a newer version of this series again sent by Jiang Xin. I'll
> try to have a look today.

Thanks. I do not particularly like "competing" parallel topics that do not talk much with each other, so I wanted to take a look at the other one, too, to see why these two are not good enough.

Show 18 quoted lines

>> * ds/path-walk-1 (2024-12-07) 7 commits
>>  - path-walk: reorder object visits
>>  - path-walk: mark trees and blobs as UNINTERESTING
>>  - path-walk: visit tags and cached objects
>>  - path-walk: allow consumer to specify object types
>>  - t6601: add helper for testing path-walk API
>>  - test-lib-functions: add test_cmp_sorted
>>  - path-walk: introduce an object walk by path
>>  (this branch is used by ds/backfill.)
>> 
>>  Introduce a new API to visit objects in batches based on a common
>>  path, or by type.
>> 
>>  Will merge to 'next'?
>>  source: <pull.1818.v3.git.1733514358.gitgitgadget@gmail.com>
>
> I was a bit late to the party, but have sent a couple of review comments
> to the mailing list late last week that Derrick may want to address.

Yup, I saw your comments.  Let's hear what Derrick says.

Show 10 quoted lines

>> * as/show-index-uninitialized-hash (2024-11-11) 2 commits
>>  - t5300: add test for 'show-index --object-format'
>>  - show-index: fix uninitialized hash function
>> 
>>  Regression fix for 'show-index' when run outside of a repository.
>> 
>>  Comments?
>>  source: <20241109092739.14276-1-abhijeet.nkt@gmail.com>
>
> I've just had a look at it, looks good to me.

Thanks. This was fairly straight-forward and looked good to me, too. Marked for 'next'.

Thanks.