git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] combine-diff: don't override recursive flag

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 4, 2025, 16:54 UTC
Message-ID
<xmqqecsm9n0u.fsf@gitster.g>
In-Reply-To
<20250904-toon-fix-last-modified-v1-1-91bf87ddf62b@iotcl.com>
Toon Claes <toon@iotcl.com> writes:
> Because internally diff-tree no longer runs recursive, this results in a
> nice speedup when running `git last-modified` on git.git:

And users of "git diff-tree -c" now needs to pass "-r" themselves to obtain the result they expect to see?

Do we need to retian backward compatibility there?  As things like this ...
Show 11 quoted lines
> diff --git a/t/t4013/diff.diff-tree_-c_master b/t/t4013/diff.diff-tree_-c_master
> index e2d2bb26114ac886fbf2467dc7a33ec8cfab5daf..1ecc2cfc6c50e923a671fba29a6a395f4240e0ff 100644
> --- a/t/t4013/diff.diff-tree_-c_master
> +++ b/t/t4013/diff.diff-tree_-c_master
> @@ -1,5 +1,5 @@
>  $ git diff-tree -c master
>  59d314ad6f356dd08601a4cd5e530381da3e3c64
> -::100644 100644 100644 cead32e925b1420c84c14cbf7cf755e7e45af8ad 7289e35bff32727c08dda207511bec138fdb9ea5 992913c5aa0a5476d10c49ed0f21fc0c6d1aedf3 MM	dir/sub
> +::040000 040000 040000 65f5c9dd60ce3b2b3324b618ac7accf8d912c113 f977ed46ae6873c1c30ab878e15a4accedc3618b 0564e026437809817a64fff393079714b6dd4628 MM	dir
>  ::100644 100644 100644 b414108e81e5091fe0974a1858b4d0d22b107f70 f4615da674c09df322d6ba8d6b21ecfb1b1ba510 10a8a9f3657f91a156b9f0184ed79a20adef9f7f MM	file0
>  $
... is a clear regression of age old expectation.

I do not mind too much if you did want to make a breaking change and be honest about it, but then I would expect you would be adding "-r" on the command line without changing the expected output in a test like the above one, i.e. I would expect that the above should look more like this:

Show 5 quoted lines
> -$ git diff-tree -c master
> +$ git diff-tree -r -c master
>  59d314ad6f356dd08601a4cd5e530381da3e3c64
>  ::100644 100644 100644 cead32e925b1420c84c14cbf7cf755e7e45af8ad 7289e35bff32727c08dda207511bec138fdb9ea5 992913c5aa0a5476d10c49ed0f21fc0c6d1aedf3 MM	dir/sub
>  ::100644 100644 100644 b414108e81e5091fe0974a1858b4d0d22b107f70 f4615da674c09df322d6ba8d6b21ecfb1b1ba510 10a8a9f3657f91a156b9f0184ed79a20adef9f7f MM	file0
Previous: Toon Claes
Message 2 of 2 in “combine-diff: don't override recursive flag”
  1. combine-diff: don't override recursive flagToon Claes, Sep 4, 2025
  2. Junio C HamanoSep 4, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.