Re: [PATCH 0/5] submodule: add 'reversive' traversal options to foreach

William Hatfield <whatfield.git@gmail.com> writes:

Not really. To be honest, I didn't even check to make sure what the behaviour was that your "--reverse" was implementing ;-).

If all three kinds of *order makes sense to the submodule traversal, then --{pre,in,post}order would make sense. In other words, does there exist a good answer to this question:

    What does "--inorder-traversal" would do and when would it be
    useful, as opposed to --preorder and --postorder?

Otherwise, the distinction between --bottom-up vs --top-down may be sufficient to explain, and may explain the concept using more familiar terms to us non-mathematics types.

Depends on what you are trying to tell the command to do with these options.

The former sounds as if you are saying "we usually do these things only in submodules and never in superproject. But with this option I am telling you to do the same in superproject after you are done doing them in all the submoudles".

On the other hand, the latter sounds more like "do these things in each and every repository (both submodules and the superproject), but make sure the repository for superproject is handled after all others."

Thanks.