git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] packfile: harden handling of packs with duplicate entries

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 24, 2026, 21:54 UTC
Message-ID
<xmqqecgs3vg6.fsf@gitster.g>
In-Reply-To
<cover.1784927134.git.ttaylorr@openai.com>
Taylor Blau <ttaylorr@openai.com> writes:
> Packfiles containing duplicate object entries are unusual, but Git
> already accepts them outside of strict indexing.

That is looser than what we intended. "unusual" -> "invalid". It is just like Git does not immediately complain until "git fsck", "git repack", or otherwise "git" tries to use the object if you corrupted loose object files under .git/objects/??/ directories.

Detecting such a problematic pack early before the problem spreads is a very welcome change.

Previous: Taylor Blau
Message 7 of 7 in “packfile: harden handling of packs with duplicate entries”
  1. 0/5 packfile: harden handling of packs with duplicate entriesTaylor Blau, Jul 24, 2026
  2. 1/5 t5308: test reverse indexes with duplicate objectsTaylor Blau, Jul 24, 2026
  3. 2/5 packfile: recover delta cycles through duplicate entriesTaylor Blau, Jul 24, 2026
  4. 3/5 midx: verify duplicate pack entries by OID and offsetTaylor Blau, Jul 24, 2026
  5. 4/5 test-tool bitmap: reject packs with duplicate objectsTaylor Blau, Jul 24, 2026
  6. 5/5 pack-bitmap: handle duplicate pack entries during MIDX reuseTaylor Blau, Jul 24, 2026
  7. Junio C HamanoJul 24, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.