Re: RLIMIT_NOFILE fallback

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2013, 21:37 UTC
Message-ID: <xmqqd2kthmcr.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20131218212847.GA13685@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> According to the POSIX quote above, it sounds like we could do:
>
>   #if defined (_SC_OPEN_MAX)
>   {
>           long max;
>           errno = 0;
>           max = sysconf(_SC_OPEN_MAX);
>           if (0 < max) /* got the limit */
>                   return max;
>           else if (!errno) /* unlimited, cast to int-max */
>                   return max;
>           /* otherwise, fall through */
>   }
>   #endif
>
> Obviously you could collapse the two branches of the conditional, though
> I think it deserves at least a comment to explain what is going on.

Yes, that is locally OK, but depending on how the caller behaves, we might need to have an extra saved_errno dance here, which I didn't want to get into...