git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Documentation: exclude irrelevant options from "git pull"

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 14, 2014, 19:54 UTC
Message-ID
<xmqqd2ju49b3.fsf@gitster.dls.corp.google.com>
In-Reply-To
<7v61pm1hfe.fsf@alter.siamese.dyndns.org>

10eb64f5 (git pull manpage: don't include -n from fetch-options.txt, 2008-01-25) introduced a way to exclude some parts of included source when building git-pull documentation, and later 409b8d82 (Documentation/git-pull: put verbosity options before merge/fetch ones, 2010-02-24) attempted to use the mechanism to exclude some parts of merge-options.txt when used from git-pull.txt.

However, the latter did not have an intended effect, because the macro "git-pull" used to decide if the source is included in git-pull documentation were defined a bit too late.

Define the macro before it is used to fix this.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * To be applied on top of 409b8d82 (Documentation/git-pull: put
   verbosity options before merge/fetch ones, 2010-02-24)
 Documentation/git-pull.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-pull.txt b/Documentation/git-pull.txt
index d47f9dd..0e7a1fe 100644
--- a/Documentation/git-pull.txt
+++ b/Documentation/git-pull.txt
@@ -42,10 +42,10 @@ OPTIONS
 Options related to merging
 ~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-include::merge-options.txt[]
-
 :git-pull: 1
 
+include::merge-options.txt[]
+
 --rebase::
 	Instead of a merge, perform a rebase after fetching.  If
 	there is a remote ref for the upstream branch, and this branch
-- 
1.8.5.3-493-gb139ac2
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “BUG: manpage for git-pull mentions a non-valid option -m in a comment”
  1. Ivan ZakharyaschevJan 14, 2014
  2. Re* manpage for git-pull mentions a non-valid option -m in a commentJunio C Hamano, Jan 14, 2014
  3. Torsten BögershausenJan 14, 2014
  4. Junio C HamanoJan 14, 2014
  5. 1/2 Documentation: exclude irrelevant options from "git pull"Junio C Hamano, Jan 14, 2014
  6. 2/2 Documentation: "git pull" does not have the "-m" optionJunio C Hamano, Jan 14, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.