git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Rewrite git-compat-util.h:skip_prefix() as a loop

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 27, 2014, 19:35 UTC
Message-ID
<xmqqd2i8z6um.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1393503197-29669-1-git-send-email-sunheehnus@gmail.com>
Sun He <sunheehnus@gmail.com> writes:
Show 17 quoted lines
> Signed-off-by: Sun He <sunheehnus@gmail.com>
> ---
>  git-compat-util.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index cbd86c3..4daa6cf 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -357,8 +357,8 @@ extern int suffixcmp(const char *str, const char *suffix);
>  
>  static inline const char *skip_prefix(const char *str, const char *prefix)
>  {
> -	size_t len = strlen(prefix);
> -	return strncmp(str, prefix, len) ? NULL : str + len;
> +    while( *prefix != '\0' && *str++ == *prefix++ );
> +    return *prefix == '\0' ? str : NULL;
Documentation/CodingGuidelines?
>  }
>  
>  #if defined(NO_MMAP) || defined(USE_WIN32_MMAP)
Previous: Sun HeNext: David Kastrup
Message 2 of 5 in “Rewrite git-compat-util.h:skip_prefix() as a loop”
  1. Rewrite git-compat-util.h:skip_prefix() as a loopSun He, Feb 27, 2014
  2. Junio C HamanoFeb 27, 2014
  3. David KastrupFeb 27, 2014
  4. Junio C HamanoFeb 27, 2014
  5. Jeff KingFeb 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.