git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: don't hardcode HEAD in dist target

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 2, 2014, 20:27 UTC
Message-ID
<xmqqd2er3vml.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140602193419.GA10198@spirit>
Dennis Kaarsemaker <dennis@kaarsemaker.net> writes:
> I'd say it would make the consistency better, because now both look at
> what is checked out instead of at HEAD.

The version with your patch does not even look at HEAD; it looks at whatever GIT_VERSION points at, which could be a very different version that does not have anything to do with what is checked out Can't GIT_VERSION come from ./version file, for example?

Previous: Dennis Kaarsemaker
Message 4 of 4 in “Makefile: don't hardcode HEAD in dist target”
  1. Makefile: don't hardcode HEAD in dist targetDennis Kaarsemaker, May 31, 2014
  2. Junio C HamanoJun 2, 2014
  3. Dennis KaarsemakerJun 2, 2014
  4. Junio C HamanoJun 2, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.