Re: [PATCH 5/9] autoconf: Check for struct itimerval

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 28, 2014, 19:38 UTC
Message-ID: <xmqqd2bk9zgd.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1409187862-21257-6-git-send-email-sortie@maxsi.org>

Jonas 'Sortie' Termansen <sortie@maxsi.org> writes:

Show 5 quoted lines

> The makefile has provisions for this case, so let's detect it in
> the configure script as well.
>
> Signed-off-by: Jonas 'Sortie' Termansen <sortie@maxsi.org>
> ---

This, 1/9 and later 7/9, are independently good changes to the current codebase, unlike all the other patches that become only necessary if/when we want to migrate to timer_settime().

As such, we would prefer to have these "fixes to the current system" at the beginning of the series before "enhancements to the current system" patches.

Thanks.

Show 21 quoted lines

>  configure.ac | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 31b3218..00842ae 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -761,6 +761,13 @@ AC_CHECK_TYPES([struct timespec],
>  [#include <sys/time.h>])
>  GIT_CONF_SUBST([NO_STRUCT_TIMESPEC])
>  #
> +# Define NO_STRUCT_ITIMERVAL if you don't have struct itimerval.
> +AC_CHECK_TYPES([struct itimerval],
> +[NO_STRUCT_ITIMERVAL=],
> +[NO_STRUCT_ITIMERVAL=UnfortunatelyYes],
> +[#include <sys/time.h>])
> +GIT_CONF_SUBST([NO_STRUCT_ITIMERVAL])
> +#
>  # Define NO_D_INO_IN_DIRENT if you don't have d_ino in your struct dirent.
>  AC_CHECK_MEMBER(struct dirent.d_ino,
>  [NO_D_INO_IN_DIRENT=],