git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] daemon: unbreak NO_IPV6 build regression

From
Junio C Hamano <gitster@pobox.com>
Date
May 5, 2015, 18:07 UTC
Message-ID
<xmqqd22eew4v.fsf_-_@gitster.dls.corp.google.com>
In-Reply-To
<xmqqioc6ewnw.fsf@gitster.dls.corp.google.com>

When 01cec54e (daemon: deglobalize hostname information, 2015-03-07) wrapped the global variables such as hostname inside a struct, it forgot to convert one location that spelled "hostname" that needs to be updated to "hi->hostname".

This was inside NO_IPV6 block, and was not caught by anybody.
Reported by: Eduardo Espejo
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/daemon.c b/daemon.c
index 9ee2187..4be1091 100644
--- a/daemon.c
+++ b/daemon.c
@@ -633,7 +633,7 @@ static void lookup_hostname(struct hostinfo *hi)
 		char **ap;
 		static char addrbuf[HOST_NAME_MAX + 1];
 
-		hent = gethostbyname(hostname.buf);
+		hent = gethostbyname(hi->hostname.buf);
 		if (hent) {
 			ap = hent->h_addr_list;
 			memset(&sa, 0, sizeof sa);
-- 
2.4.0-311-gf1d9b8d
Previous: Junio C HamanoNext: René Scharfe
Message 3 of 4 in “[BUG] deamon.c does not compile when NO_IPV6 is used”
  1. Eduardo EspejoMay 5, 2015
  2. Junio C HamanoMay 5, 2015
  3. daemon: unbreak NO_IPV6 build regressionJunio C Hamano, May 5, 2015
  4. René ScharfeMay 18, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.