Re: [PATCH] rev-list: add --count to usage guide

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2015, 15:19 UTC
Message-ID: <xmqqd20bc3cj.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1435742651-15053-1-git-send-email-lawrencesiebert@gmail.com>

Lawrence Siebert <lawrencesiebert@gmail.com> writes:

Show 5 quoted lines

> --count should be mentioned in the usage guide, this updates code and
> documentation.
>
> Signed-off-by: Lawrence Siebert <lawrencesiebert@gmail.com>
> ---

Sounds good. While at it, perhaps add a mention (perhaps by creating a BUGS section at the end of the file) that --count with --use-bitmap-index ignores pathspec silently?

Show 28 quoted lines

>  Documentation/git-rev-list.txt | 1 +
>  builtin/rev-list.c             | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt
> index b10ea60..7b49c85 100644
> --- a/Documentation/git-rev-list.txt
> +++ b/Documentation/git-rev-list.txt
> @@ -56,6 +56,7 @@ SYNOPSIS
>  	     [ --reverse ]
>  	     [ --walk-reflogs ]
>  	     [ --no-walk ] [ --do-walk ]
> +	     [ --count ]
>  	     [ --use-bitmap-index ]
>  	     <commit>... [ \-- <paths>... ]
>  
> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> index ff84a82..ee9e872 100644
> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -42,6 +42,7 @@ static const char rev_list_usage[] =
>  "    --abbrev=<n> | --no-abbrev\n"
>  "    --abbrev-commit\n"
>  "    --left-right\n"
> +"    --count\n"
>  "  special purpose:\n"
>  "    --bisect\n"
>  "    --bisect-vars\n"