git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 2/3] path: optimize common dir checking

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 5, 2015, 17:22 UTC
Message-ID
<xmqqd1wtz0w2.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<5611E7B1.3090001@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 8 quoted lines
> For this particular application, where we only have 19 strings to store,
> I suppose we could tolerate the use of approximately 64k of RAM to store
> 174 characters worth of strings *if* it would bring us big time savings.
> But I think we need some evidence of the time savings.
>
> If this lookup is really a bottleneck, I bet there are other
> alternatives that are just as fast as this trie and use less code,
> especially given that there are only 19 strings that need checking.

Very good point. I agree that we need to know that the dumb linear scan in the original is on the bottleneck and that any replacement is an improvement.

Previous: Michael HaggertyNext: David Turner
Message 5 of 10 in “(unknown)”
  1. David TurnerSep 1, 2015
  2. 1/3 refs: clean up common_listDavid Turner, Sep 1, 2015
  3. 2/3 path: optimize common dir checkingDavid Turner, Sep 1, 2015
  4. Michael HaggertyOct 5, 2015
  5. Junio C HamanoOct 5, 2015
  6. David TurnerOct 5, 2015
  7. Junio C HamanoOct 5, 2015
  8. Junio C HamanoOct 5, 2015
  9. 3/3 refs: make refs/bisect/* per-worktreeDavid Turner, Sep 1, 2015
  10. Junio C HamanoSep 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.