Re: [PATCH v2 1/3] pull: allow interactive rebase with --rebase=interactive

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 13, 2016, 17:36 UTC
Message-ID: <xmqqd1t5pej1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <2ebf99214ba600b63a39c58bcb9abb7941a7619d.1452668201.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 5 quoted lines

> The way builtin pull works, this change also supports the value
> 'interactive' for the 'branch.<name>.rebase' config variable, which
> is a neat thing because users can now configure given branches for
> interactively-rebasing pulls without having to type out the complete
> `--rebase=interactive` option every time they pull.

Surely this is a better description about the "config also works and it is a good thing" part. What I was alluding to was actually this you wrote in 0/3:

    A couple of years ago, I found the need to collaborate on topic
    branches that were rebased all the time, and I really needed to
    see what I was rebasing when pulling, so I introduced an
    interactively-rebasing pull.

that justifies why allowing 'pull' to invoke interactive rebase is a good thing, which should go before all of the above five lines.

I see you have v3 already (and I read Paul's "you missed these"), which I haven't read yet, but I expect the actual changes are good and no longer need rerolling, so I may just insert these four lines at the beginning of the log message while queuing, or something.

Thanks, both.