Re: [PATCH v5 2/3] config: add 'type' to config_source struct that identifies config type

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 17, 2016, 21:31 UTC
Message-ID: <xmqqd1rvhvmq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqa8mzjh7d.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> larsxschneider@gmail.com writes:
>
>> From: Lars Schneider <larsxschneider@gmail.com>
>>
>> Use the config type to print more detailed error messages that inform
>> the user about the origin of a config error (file, stdin, blob).
>
> "type" is too broad a word in the context of configuration file, and
> does not help readers as a variable or a field name in a structure.
> You are not talking about "this is a binary typed variable", for
> example.
>
> If showing the origin is useful to the user, that origin should be
> called origin, not type, I would think.

You seem to use in 3/3 "origin type", and I think that is a sensible phrasing. Renaming 'type' to 'origin' in this patch would not be a good idea, but renaming it to 'origin_type' would be a great thing to do.

In the context of configuration parsing, 'origin' would be like "file called .git/config", "standard input", "command line's 3rd argument", etc., i.e. for some origin types, it would consist of <origin_type=file, origin_value=.git/config> pair, while some other origin type (e.g. "standard input") there is no need for an "origin_value" that further qualifies the origin.

Thanks.