Re: [PATCH] git-svn: allow --version to work anywhere
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 28, 2016, 21:23 UTC
- Message-ID
- <xmqqd1lxqwxf.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqtwf9r013.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 17 quoted lines
> Eric Wong <e@80x24.org> writes: > >> Repushed my master in case it's a convenient time to pull. >> >> The following changes since commit 29493589e97a2de0c4c1c314f61ccafaee3b5caf: >> >> archive-tar: huge offset and future timestamps would not work on 32-bit (2016-07-15 10:51:55 -0700) >> >> are available in the git repository at: >> >> git://bogomips.org/git-svn.git master >> >> for you to fetch changes up to c0071ae5dc1c610ab3791ece7ccf7d4772fde151: >> >> git-svn: allow --version to work anywhere (2016-07-22 20:38:11 +0000) > > Thanks, pulled.
I was too deep in today's integration cycle to waste half-day's work, so I added this hotfix after the merge, directly on 'master'.
-- >8 -- Subject: [PATCH] t9100: portability fix
Do not say "export VAR=VAL"; "VAR=VAL && export VAR" is always more portable.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/t9100-git-svn-basic.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-basic.sh index ab6593b..d29f601 100755 --- a/t/t9100-git-svn-basic.sh +++ b/t/t9100-git-svn-basic.sh @@ -24,7 +24,8 @@ ceiling=$PWD test_expect_success 'git svn --version works anywhere' ' mkdir -p "$deepdir" && ( - export GIT_CEILING_DIRECTORIES="$ceiling" && + GIT_CEILING_DIRECTORIES="$ceiling" && + export GIT_CEILING_DIRECTORIES && cd "$deepdir" && git svn --version ) @@ -32,7 +33,8 @@ test_expect_success 'git svn --version works anywhere' ' test_expect_success 'git svn help works anywhere' ' mkdir -p "$deepdir" && ( - export GIT_CEILING_DIRECTORIES="$ceiling" && + GIT_CEILING_DIRECTORIES="$ceiling" && + export GIT_CEILING_DIRECTORIES && cd "$deepdir" && git svn help )
-- 2.9.2-662-gbb82c05