Re: [PATCH v3] remote-curl: don't hang when a server dies before any output

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 18, 2016, 21:05 UTC
Message-ID: <xmqqd1hsmrbw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1479501049-15458-1-git-send-email-dturner@twosigma.com>

David Turner <dturner@twosigma.com> writes:

Show 16 quoted lines

> In the event that a HTTP server closes the connection after giving a
> 200 but before giving any packets, we don't want to hang forever
> waiting for a response that will never come.  Instead, we should die
> immediately.
>
> One case where this happens is when attempting to fetch a dangling
> object by SHA.  In this case, the server dies before sending any data.
> Prior to this patch, fetch-pack would wait for data from the server,
> and remote-curl would wait for fetch-pack, causing a deadlock.
> ...
> Still to do: it would be good to give a better error message
> than "fatal: The remote end hung up unexpectedly".
>
> Signed-off-by: David Turner <dturner@twosigma.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---

Thanks.