Re: [PATCHv3 1/3] merge: Add '--continue' option as a synonym for 'git commit'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 15, 2016, 17:36 UTC
- Message-ID
- <xmqqd1gtw0vi.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAFOYHZD_mFMvggq4pedjGCz332i1-VcRKxu30iMzURfB3Mu8Vg@mail.gmail.com>
Chris Packham <judge.packham@gmail.com> writes:
Show 9 quoted lines
> On Thu, Dec 15, 2016 at 7:04 AM, Junio C Hamano <gitster@pobox.com> wrote: >> The last one 3/3 is a nice touch that makes sure that we do not >> forget what we discovered during the discussion. Very much >> appreciated. >> >> Will queue. Thanks. > > Did you want me to send a v4 to mark the strings for translation or > will you apply a fixup your end?
I didn't follow the _() discussion (was there any?)
I do not think lack of _() is a show-stopper and my preference is to keep what I queued that does not have _(), and receive a separate follow-up patch that changes "msg" to _("msg") and does nothing else.
Thanks.