git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/regex: fix compilation on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
May 12, 2017, 01:18 UTC
Message-ID
<xmqqd1be98kk.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<6a6782863a74432094a1d7fba7f2477991ef2d16.1494510612.git.johannes.schindelin@gmx.de>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> The real issue here is that GNU awk's regex implementation assumes a bit
> too much about the relative sizes of pointers and long integers. What they
> really want is to use intptr_t.

Good. I got annoyed enough to do the same myself before opening my mailbox. One thing that is curious about your version is that it still has "#include <stdint.h>" behind HAVE_STDINT_H; when I tried to compile an equivalent of your change last night, the compilation failed because intptr_t wasn't available without exposing <stdint.h>

Where is Windows build getting its intptr_t, I wonder.
Previous: Ævar Arnfjörð BjarmasonNext: Johannes Schindelin
Message 3 of 10 in “compat/regex: fix compilation on Windows”
  1. compat/regex: fix compilation on WindowsJohannes Schindelin, May 11, 2017
  2. Ævar Arnfjörð BjarmasonMay 11, 2017
  3. Junio C HamanoMay 12, 2017
  4. Johannes SchindelinMay 12, 2017
  5. Ramsay JonesMay 12, 2017
  6. Junio C HamanoMay 12, 2017
  7. Ævar Arnfjörð BjarmasonMay 12, 2017
  8. Johannes SchindelinMay 13, 2017
  9. Ævar Arnfjörð BjarmasonMay 13, 2017
  10. Junio C HamanoMay 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.