Re: [PATCH 1/2] Document git config getter return value.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 30, 2018, 20:03 UTC
- Message-ID
- <xmqqd0v4fq4n.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAPig+cQkFHtOw=gJ1Y5vjQipeAgRon214tUs09o3k3LkevHu4g@mail.gmail.com>
Eric Sunshine <sunshine@sunshineco.com> writes:
Show 6 quoted lines
> On Mon, Jul 30, 2018 at 8:26 AM Han-Wen Nienhuys <hanwen@google.com> wrote: >> --- >> config.h | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) > > Missing sign-off.
Besides, the patch is corrupt in that it miscounts both preimage and postimage lines and claims it applies to a 11-line block even though there are only 10 lines there.