Re: [PATCH 1/3] t7001: reformat to newer style
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 25, 2018, 20:36 UTC
- Message-ID
- <xmqqd0t1pb4t.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAGZ79kaeWa5PRregdoJp82sSsY1-GF7kk33fxf1kbTPcZWu-bg@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
> Heh, thanks for calling that out. So we're looking at a full formatter > instead of a partial formatter that helps moving in the right direction now. :-/
The parts left out of these patches (e.g. use subshell when working in a subdirectory) need human decision and a bit of good taste, and I think it was a good design decision to keep these three patches all mechanical. There do need a follow-up [PATCH {4,5,6}/3] that cannot be done mechanically, though, before the result can be called "this script has been cleaned up and new people are encouraged to mimick the way it does things".
That way, we can keep the mechanically good bits that are early in the series while polishing the later bits that need human judgement.