Re: [PATCH v1 0/2] document deprecation of log.mailmap=false default

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2019, 19:30 UTC
Message-ID: <xmqqd0ifoxtu.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAAOiGNzcNhWmmr+COXhv2p9=KF5k4hHLEsNsfA1H+P0JQOTTqg@mail.gmail.com>

Ariadne Conill <ariadne@dereferenced.org> writes:

Show 18 quoted lines

>> 4212.4 raises an interesting question.  It wants to see the output
>> of this command:
>>
>>         git log --format="%an+%ae+%ad" broken_email >actual.out 2>actual.err &&
>>
>> The question is, when the user explicitly asked for the "true"
>> identity values (not the mapped one via %aN, %aE and their friends),
>> if --use-mailmap should affect the outcome?
>
> I don't think it should.
>
>> A secondary question is if we should be issuing a warning against
>> this command line in the first place, if the answer to the above
>> question is "no" (i.e. --[no-]use-mailmap, and the future default
>> switch, do not affect the outcome).  There is no point issuing a
>> warning if the command line is already future-proofed.
>
> I will disable the warning if a custom format is specified.

I briefly thought that this is tricky enough that we should wait for other people to chime in before casting the decision in stone. But we can continue with what we consider the better variant in the meantime.

> A thought I had was to perhaps use isatty(STDERR_FILENO) to determine
> if stderr is attached to a terminal session and only issue the warning
> in that case.  What do you think?  It should fix all of these tests.

Some of them but it should not affect that one, which is run under test_terminal, as the whole point of that test helper is to see how we behave in a terminal ;-)

> Thanks wholeheartedly for all of your help so far, I know there are
> many git users who will be very happy once all of this work is done
> (basically anyone who has changed their name).

Thanks.