Re: [PATCH] doc: use 'ref' instead of 'commit' for merge-base arguments

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 3, 2020, 14:30 UTC
Message-ID: <xmqqd09ta4tn.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2003031507500.46@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 10 quoted lines

>> > The notation <commit> can be misunderstandable only for commit SHA1,
>> > but merge-base accepts any commit references. Like reflog, the name of
>> > arguments should be <ref> instead of <commit>.
>>
>> To me, this change goes too far in the opposite direction: Now it
>> sounds like the command only accepts refs, when it actually accepts
>> any "commit-ish"--i.e., anything that can be coerced to a commit.
>> ("git worktree" uses this term in its usage for "add", for example.)
>
> Maybe we can go for `rev` instead of `ref`?

That's much better than 'ref', but I do not see why 'commit' is wrong in the first place. There are many ways to name an object, and `rev` is an old colloquial way to say "object name". Here, however, we want only commit objects, no?