Re: [PATCH v13 1/5] help: move list_config_help to builtin/help
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 16, 2020, 22:21 UTC
- Message-ID
- <xmqqd087xe9x.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200416211807.60811-2-emilyshaffer@google.com>
Emily Shaffer <emilyshaffer@google.com> writes:
Show 29 quoted lines
> Starting in 3ac68a93fd2, help.o began to depend on builtin/branch.o, > builtin/clean.o, and builtin/config.o. This meant that help.o was > unusable outside of the context of the main Git executable. > > To make help.o usable by other commands again, move list_config_help() > into builtin/help.c (where it makes sense to assume other builtin libraries > are present). > > When command-list.h is included but a member is not used, we start to > hear a compiler warning. Since the config list is generated in a fairly > different way than the command list, and since commands and config > options are semantically different, move the config list into its own > header and move the generator into its own script and build rule. > > Signed-off-by: Emily Shaffer <emilyshaffer@google.com> > > msvc: the bugreport topic depends on a generated config-list.h file > > For reasons explained in 976aaedc (msvc: add a Makefile target to > pre-generate the Visual Studio solution, 2019-07-29), some build > artifacts we consider non-source files cannot be generated in the > Visual Studio environment, and we already have some Makefile tweaks > to help Visual Studio to use generated command-list.h header file. > > As this topic starts to depend on another such generated header file, > config-list.h, let's do the same to it. > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > ---
Forgot to proofread and edit the log message into reasonable shape when you squashed two patches together?
I wonder if the "squash" action of "rebase -i" can be taught to detect a mistake like this?