git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: add \t to reflog in the files backend

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 31, 2020, 17:17 UTC
Message-ID
<xmqqd04b4nak.fsf@gitster.c.googlers.com>
In-Reply-To
<pull.688.git.1596195370757.gitgitgadget@gmail.com>
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 7 quoted lines
> From: Han-Wen Nienhuys <hanwen@google.com>
>
> commit 523fa69c3 (Jul 10, 2020) "reflog: cleanse messages in the
> refs.c layer" centralized reflog normalizaton.  However, the
> normalizaton added a leading "\t" to the message. This is an artifact
> of the reflog storage format in the files backend, so it should be
> added there.

I agree with you that it makes sense to move the logic to add "\t" before the log message from generic layer to the backend. Thanks for spotting and correcting.

Will queue.
Previous: Han-Wen Nienhuys via GitGitGadgetNext: Jeff King
Message 2 of 3 in “refs: add \t to reflog in the files backend”
  1. refs: add \t to reflog in the files backendHan-Wen Nienhuys via GitGitGadget, Jul 31, 2020
  2. Junio C HamanoJul 31, 2020
  3. Jeff KingJul 31, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.