git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: fix interleaving hook calls with reference-transaction hook

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 7, 2020, 19:26 UTC
Message-ID
<xmqqd042gsve.fsf@gitster.c.googlers.com>
In-Reply-To
<20200807182141.GA1307024@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> On Fri, Aug 07, 2020 at 11:49:46AM +0200, Patrick Steinhardt wrote:
>
>> Yeah, it's also been my take that OS-level overhead is probably going to
>> matter more than those access calls, and I argued such back when I
>> proposed the hook. So I'm perfectly happy to see this caching mechanism
>> go.
>> 
>> Should I re-post a v2 with your patch and my test?
>
> Sure, that would be fine (to be clear, I'd also be OK with your original
> patch, too; it was mostly just a curiosity to me).
Let's queue the correctness fix patch as-is.

We can and should make the simplification as a separate step, justified with the performance numbers.

Thanks.
Previous: Jeff King
Message 9 of 9 in “refs: fix interleaving hook calls with reference-transaction hook”
  1. refs: fix interleaving hook calls with reference-transaction hookPatrick Steinhardt, Aug 7, 2020
  2. Jeff KingAug 7, 2020
  3. Patrick SteinhardtAug 7, 2020
  4. Jeff KingAug 7, 2020
  5. Patrick SteinhardtAug 7, 2020
  6. Junio C HamanoAug 7, 2020
  7. Jeff KingAug 7, 2020
  8. Jeff KingAug 7, 2020
  9. Junio C HamanoAug 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.