git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git add intent-to-add then git add patch no longer allows edit

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 6, 2020, 17:10 UTC
Message-ID
<xmqqd02y7rwj.fsf@gitster.c.googlers.com>
In-Reply-To
<nycvar.QRO.7.76.6.2009040831570.56@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Thanks for reminding me, I did not really think about it anymore. The
> built-in `git add -i`/`git add -p` has been available since v2.25.0. Since
> v2.26.0, we also respect that flag in the `-p` modes of `checkout`,
> `stash`, etc
That is 9a5315ed (Merge branch 'js/patch-mode-in-others-in-c', 2020-02-05)
> And from the way at least _I_ read the commit log, it seems that the code
> has been pretty stable (except for that bug fix where `e` was allowed by
> mistake).

As long as it has been widely used, that is. I do not think we deeply mind a bug like the `e` one that does not affect the utility or the correctness of the command that much. If we do not flip the "use the built-in variant" for those with feature.experimental we really should do so to widen the canarying population immediately.

Previous: Johannes SchindelinNext: Phillip Wood
Message 10 of 16 in “git add intent-to-add then git add patch no longer allows edit”
  1. Thomas SullivanAug 21, 2020
  2. Raymond E. PascoAug 21, 2020
  3. Junio C HamanoAug 21, 2020
  4. Phillip WoodAug 23, 2020
  5. Raymond E. PascoAug 24, 2020
  6. Phillip WoodAug 24, 2020
  7. Raymond E. PascoAug 24, 2020
  8. Phillip WoodSep 4, 2020
  9. Johannes SchindelinSep 4, 2020
  10. Junio C HamanoSep 6, 2020
  11. Phillip WoodSep 7, 2020
  12. Junio C HamanoSep 8, 2020
  13. Johannes SchindelinSep 8, 2020
  14. Junio C HamanoSep 8, 2020
  15. Phillip WoodSep 9, 2020
  16. Raymond E. PascoSep 5, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.