Re: [PATCH 3/3] builtin/repack.c: don't move existing packs out of the way
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2020, 00:46 UTC
- Message-ID
- <xmqqd00c7qup.fsf@gitster.c.googlers.com>
- In-Reply-To
- <X7MYifflg7SaTRXm@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 11 quoted lines
>> In any case, much of what I speculated while reading the proposed >> log message turned out to be false, which may be a sign that the log >> message did not explain the approach clearly enough. I thought that >> a newly created file that happened to be identical to existing ones >> would be discarded without getting renamed to their final location, >> but the code does not do such special casing. I thought the >> 'metadata' it talks about were to compensate for side effects of >> reusing the old files, but that was not what the 'metadata' was even >> about. > > It's more about: ...
You do not have to explain that to me here. Instead explain that to future readers of our history in the commit log message.
Thanks.