git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] builtin/repack.c: don't move existing packs out of the way

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 17, 2020, 00:46 UTC
Message-ID
<xmqqd00c7qup.fsf@gitster.c.googlers.com>
In-Reply-To
<X7MYifflg7SaTRXm@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 11 quoted lines
>> In any case, much of what I speculated while reading the proposed
>> log message turned out to be false, which may be a sign that the log
>> message did not explain the approach clearly enough.  I thought that
>> a newly created file that happened to be identical to existing ones
>> would be discarded without getting renamed to their final location,
>> but the code does not do such special casing.  I thought the
>> 'metadata' it talks about were to compensate for side effects of
>> reusing the old files, but that was not what the 'metadata' was even
>> about.
>
> It's more about: ...

You do not have to explain that to me here. Instead explain that to future readers of our history in the commit log message.

Thanks.
Previous: Taylor BlauNext: Taylor Blau
Message 9 of 11 in “repack: don't move existing packs out of the way”
  1. 0/3 repack: don't move existing packs out of the wayTaylor Blau, Nov 16, 2020
  2. 1/3 repack: make "exts" array available outside cmd_repack()Taylor Blau, Nov 16, 2020
  3. 2/3 builtin/repack.c: keep track of what pack-objects wroteTaylor Blau, Nov 16, 2020
  4. 3/3 builtin/repack.c: don't move existing packs out of the wayTaylor Blau, Nov 16, 2020
  5. Junio C HamanoNov 16, 2020
  6. Jeff KingNov 17, 2020
  7. Taylor BlauNov 17, 2020
  8. Taylor BlauNov 17, 2020
  9. Junio C HamanoNov 17, 2020
  10. Taylor BlauNov 17, 2020
  11. Junio C HamanoNov 17, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.