git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib.sh: set COLUMNS=80 for --verbose repeatability

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 29, 2021, 01:42 UTC
Message-ID
<xmqqczs530qa.fsf@gitster.g>
In-Reply-To
<20210627074419.GH6312@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
> This issue is not progress-specific.

As discussed elsewhere with Dscho on a Windows specific workaround, progress is not the only consumer of term_columns() and the code being "fixed" here would affect other things like "diff --stat" and hunk header title (aka funcname).

Together with a typo Peff pointed out, the patch deserves an updated log message before it becomes ready. The patch text looks good.

Thanks.
Previous: SZEDER GáborNext: Ævar Arnfjörð Bjarmason
Message 9 of 10 in “progress.c tests: fix breakage with COLUMNS != 80”
  1. progress.c tests: fix breakage with COLUMNS != 80Ævar Arnfjörð Bjarmason, Jun 21, 2021
  2. Jeff KingJun 23, 2021
  3. SZEDER GáborJun 24, 2021
  4. Jeff KingJun 24, 2021
  5. Philip OakleyJun 24, 2021
  6. test-lib.sh: set COLUMNS=80 for --verbose repeatabilityÆvar Arnfjörð Bjarmason, Jun 24, 2021
  7. Jeff KingJun 24, 2021
  8. SZEDER GáborJun 27, 2021
  9. Junio C HamanoJun 29, 2021
  10. test-lib.sh: set COLUMNS=80 for --verbose repeatabilityÆvar Arnfjörð Bjarmason, Jun 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.