Re: [PATCH v2] fetch: do not run a redundant fetch from submodule

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2022, 15:53 UTC
Message-ID: <xmqqczgayh01.fsf@gitster.g>
In-Reply-To: <kl6lo7zwhzsl.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

Show 16 quoted lines

>> +
>> +	/*
>> +	 * This is only needed after fetch_one(), which does not fetch
>> +	 * submodules by itself.
>> +	 *
>> +	 * When we fetch from multiple remotes, fetch_multiple() has
>> +	 * already updated submodules to grab commits necessary for
>> +	 * the fetched history from each remote, so there is no need
>> +	 * to fetch submodules from here.
>> +	 */
>> +	if (!result && remote && (recurse_submodules != RECURSE_SUBMODULES_OFF)) {
>>  		struct strvec options = STRVEC_INIT;
>>  		int max_children = max_jobs;
>
> Looks good; the comment is easier to understand than my suggestion for
> sure.

Thanks. Today's code has diverged too much from the original code I wrote long time ago (before submodules), and I needed an extra set of eyeballs to double check and tell me that what I (wishfully) wrote how the code works with submodules is in line with today's code ;-)