Re: [PATCH v2] git-p4: fix bug with encoding of p4 client name

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2022, 16:36 UTC
Message-ID: <xmqqcze2s7h0.fsf@gitster.g>
In-Reply-To: <pull.1285.v2.git.git.1658134679233.gitgitgadget@gmail.com>

"Kilian Kilger via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 10 quoted lines

> From: Kilian Kilger <kkilger@gmail.com>
>
> The Perforce client name can contain arbitrary characters
> which do not decode to UTF-8. Use the fallback strategy
> implemented in metadata_stream_to_writable_bytes() also
> for the client name.
>
> Signed-off-by: Kilian Kilger <kkilger@gmail.com>
> ---
>     git-p4: Fix bug with encoding of P4 client name

Sorry, is this to improve the topic that has already last Monday?

If so, it is way too late to update with a replacement patch, like this. Instead, please send in a follow-up patch on top of what has already been merged.

The description above seems to be identical to what was in the previous round, but the patch seems to use a lot more code, so such a follow-up patch would have plenty to explain how the new strategy improves over the previous one.

Thanks.