Re: [PATCH] refs: unify parse_worktree_ref() and ref_type()

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2022, 16:45 UTC
Message-ID: <xmqqczbo65h8.fsf@gitster.g>
In-Reply-To: <CAFQ2z_PQFtq-ph1B0tUFDW7ngVwg9++k2M_5rvozsLVisX2+Qg@mail.gmail.com>

Han-Wen Nienhuys <hanwen@google.com> writes:

Show 17 quoted lines

> On Mon, Sep 19, 2022 at 11:43 PM Junio C Hamano <gitster@pobox.com> wrote:
>> > On Tue, Sep 13, 2022 at 5:43 PM Junio C Hamano <gitster@pobox.com> wrote:
>> >> then a better approach would be to have a small helper
>> >> parse_local_worktree_ref() and make the primary one into something
>> >> like
>> >>...
>> >
>> > Thanks, good idea. I'm sending you a v2.
>>
>> is that "v2" <pull.1325.v2.git.git.1663605291172.gitgitgadget@gmail.com>
>> or is there another version of it?
>
> I think so.
>
>> Hmph,
>
> Did I do something wrong?

Not "wrong" per-se, but I was surprised by the patch that looked quite different from what I expected from your response to the "small helper" suggestion.