Re: [PATCH v2] t1016: clean up style

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 3, 2024, 23:42 UTC
Message-ID: <xmqqcyjbyjdg.fsf@gitster.g>
In-Reply-To: <66df52dd-1b7c-4ca8-9752-646b5b223feb@app.fastmail.com>

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

Show 9 quoted lines

>> +	test_expect_success $PREREQ "Verify ${type} ${name}'s sha1 oid" '
>> +		git --git-dir=repo-sha256/.git rev-parse --output-object-format=sha1
>> ${sha256_oid} >${name}_sha1 &&
>> +		test_cmp ${name}_sha1 ${name}_sha1_expected
>> +	'
>
> At this point it _looks like_ some `test_expect_success` are moved
> around.  But my diff deceives me: all of the eight `test_` are provided
> in the same order in the preimage and postimage.

Yes, the output from "git show --histogram" seems to match the corresponding blocks in preimage and postimage better in this case.

Thanks, both.