git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t/unit-tests: match functions signature with trailing code

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 8, 2025, 15:27 UTC
Message-ID
<xmqqcygxpbpy.fsf@gitster.g>
In-Reply-To
<Z34XvPjhY15MFHrT@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> So I agree with you, let's scrap the idea and have proper function
> bodies instead.
Yup, sometimes, simple, stupid, and good enough is the way to go.
We could do
-- >8 --
#define T(testname, input, expect1, expect256) \
	void test_hash__ ## testname(void) \
	{ \
		const char *expect[] = { expect1, expect256 }; \
		check_hash_data(input, strlen(input), expect); \
	} extern void test_hash__ ## testname()

T(empty_string, "", "da39...", "e3b0c4..."); T(single_character, "a", "86f7e4...", "ca97811...");

-- 8< --
which may not upset syntax-aware editors too much.

Unless there are more than several dozens of them, I do not think it is worth it, though ;-)

Previous: Seyi ChamberNext: Patrick Steinhardt
Message 7 of 18 in “t/unit-tests: convert hash tests to use clar”
  1. 0/2 t/unit-tests: convert hash tests to use clarSeyi Kuforiji, Jan 7, 2025
  2. 1/2 t/unit-tests: match functions signature with trailing codeSeyi Kuforiji, Jan 7, 2025
  3. Junio C HamanoJan 7, 2025
  4. Junio C HamanoJan 7, 2025
  5. Patrick SteinhardtJan 8, 2025
  6. Seyi ChamberJan 8, 2025
  7. Junio C HamanoJan 8, 2025
  8. Patrick SteinhardtJan 8, 2025
  9. 2/2 t/unit-tests: convert hash to use clar test frameworkSeyi Kuforiji, Jan 7, 2025
  10. 0/1 t/unit-tests: convert hash to use clar test frameworkSeyi Kuforiji, Jan 8, 2025
  11. 1/1 t/unit-tests: convert hash to use clar test frameworkSeyi Kuforiji, Jan 8, 2025
  12. Junio C HamanoJan 8, 2025
  13. Seyi ChamberJan 9, 2025
  14. Junio C HamanoJan 8, 2025
  15. Seyi ChamberJan 9, 2025
  16. t/unit-tests: convert hash to use clar test frameworkSeyi Kuforiji, Jan 9, 2025
  17. Patrick SteinhardtJan 9, 2025
  18. Junio C HamanoJan 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.